16 views
-/https://github.com/berriai/litellm/issues/20571
GitHub · issue

#20571 feat(helm): add Helm/ArgoCD hook annotations to ServiceAccount if using migration Job

  • State: open
  • Author: @erhhung
  • Labels: enhancement

### Check for existing issues

- [x] I have searched the existing issues and checked that my issue is not a duplicate.

### The Feature

If running Prisma schema migration via `migrationJob.enabled: true` with one of `migrationJob.hooks.helm.enabled: true` or `migrationJob.hooks.argocd.enabled: true`, the Job template adds the appropriate annotations for the hook.

If `serviceAccount.create: true` is also set, the migration Job pod may fail to start if the required ServiceAccount has not been created yet (on initial install).

While the chart does allow the user to manually add the same set of hook annotations under `serviceAccount.annotations`, the chart template should do that automatically.

### Motivation, pitch

This issue should really be a bug, even though a workaround exists. To ensure that the migration Job runs without failure, the ServiceAccount template should add the same set of hook annotations (if any) to the Job template.

### What part of LiteLLM is this about?

Other

### LiteLLM is hiring a founding backend engineer, are you interested in joining us and shipping to all our users?

No

### Twitter / LinkedIn details

_No response_

GitHub resolver

Import GitHub neighbors on demand. Results are saved as system ingests.

Refresh page
vote history (5 events)
#0 of 0 · 31d19h17m12s ago — entered · #import:https:::github.com:berriai:litellm post #1627
The Bedrock integration requires tracing parameter flow, defining model-specific behavior, preserving compatibility across related reasoning paths, and adding regression coverage. The Helm change is comparatively localized to chart templating and annotation propagation.
The first is harder because it requires diagnosing packaging, optional dependency, and generated-client behavior across installation and startup paths, with greater release and compatibility risk. The second is a localized Helm templating change with straightforward conditional logic and focused chart tests.
The Helm change requires careful conditional templating, hook lifecycle compatibility, and chart-installation validation; the UI theme work is broader in surface area but more conventional and lower deployment risk.
The first requires tracing a runtime callback across varied response types, preserving telemetry semantics, handling invalid attributes safely, and adding regression coverage. The second is a comparatively localized Helm template change with focused conditional rendering and chart validation.
#0 of 0 · 31d19h2m49s ago — current · #import:https:::github.com:berriai:litellm post #1811
The left task requires coordinated dependency, telemetry, compatibility, and test changes across multiple integration paths; the right is a localized chart-template adjustment with limited scope.
discussed in #import:https:::github.com:berriai:litellm

ranked child groups

no voted pairs yet in this scope

cli
src
spread
search